Add HEVC RefPicSetLtCurr and NumPocLtCurr picture parameters#853
Open
nowrep wants to merge 1 commit intointel:masterfrom
Open
Add HEVC RefPicSetLtCurr and NumPocLtCurr picture parameters#853nowrep wants to merge 1 commit intointel:masterfrom
nowrep wants to merge 1 commit intointel:masterfrom
Conversation
Jexu
reviewed
May 6, 2025
Contributor
Jexu
left a comment
Jexu
left a comment
There was a problem hiding this comment.
RefPicSetStCurrBefore, RefPicSetStCurrAfter and RefPicSetLtCurr could be all derived by sorting ReferenceFrames. And you can refer to it in media driver.
Contributor
Author
|
That's not enough, because this way the lists will be in the order as they appear in DPB. But the order here does matter, so this is wrong. The correct order of RefPicSetStCurrBefore and RefPicSetStCurrAfter can be derived by sorting them by POC (desc/asc). But this is not possible for RefPicSetLtCurr as the order is as it appear in the slice header (and the spec doesn't require them to be sorted as is the case with short term refs). Since there is no way to derive this, the RefPicSetLtCurr must be provided by application. |
Corresponds to the variables of same name as defined in section 8.3.2 of the HEVC spec. The RefPicSetStCurrBefore and RefPicSetStCurrAfter can be derived by sorting them, however there is no defined order for the RefPicSetLtCurr and thus it must be provided explicitly. This is needed for AMD driver and also to match the DXVA and Vulkan Video interfaces. Signed-off-by: David Rosca <david.rosca@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponds to the variables of same name as defined in section 8.3.2 of the HEVC spec.
The RefPicSetStCurrBefore and RefPicSetStCurrAfter can be derived by sorting them, however there is no defined order for the RefPicSetLtCurr and thus it must be provided explicitly.
This is needed for AMD driver and also to match the DXVA and Vulkan Video interfaces.